Add unread filter to entries pages #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to filter for unread pages in the filters menu.
|
Hello @danbartram! Can you add a new test like this one please? https://github.com/wallabag/wallabag/blob/master/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php#L455 What happened if you tick the new checkbox and the Archived one? |
|
@nicosomb I sure can, sorry for missing the test out. How would you like it resubmitted? As a new PR or as an extra commit?
No entries are returned, as the query will be asking for entries |
|
An extra commit ;-) |
Add a new test to the EntryControllerTest collection which checks that only entries which have not been archived (and are treated as "unread") are retrieved.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature: Filter Unread
This PR allows users to filter their entries and requiring items to be "unread".
* I'm getting a couple of PHPUnit test errors/failures, but they also exist on versions without this change.
Possible Issues
There is some coupling caused by the SQL query that might cause future issues if the schema/Doctrine design changes.
Currently in EntryFilterType.php the column for finding the read/unread status is also the archived status column. This uses the same logic as the "Unread" page view.
However, in the query you can see that the field
e.isArchivedis hard-coded and won't change if/when the Doctrine models' parameters do.If there is a better way to design this please let me know, this solution works but it doesn't seem the best design to me.