Added creation date and reading time on article view #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% set readingTime = entry.readingTime / app.user.config.readingSpeed %} | ||
| <div class="link mdi-action-query-builder"> {% if readingTime > 0 %}{{ 'entry.list.reading_time_minutes_short'|trans({'%readingTime%': readingTime|round}) }} | ||
| {% else %}{{ 'entry.list.reading_time_less_one_minute_short'|trans|raw }} | ||
| {% endif %}</div> |
There was a problem hiding this comment.
Can't this be displayed more nicely? I mean, it's hard to read the if / else / endif with that kind of indentation.
|
Seems good. Am I the only one that the font kind of disturbs ? Or is it the margin around the icons ? |
nicosomb
force-pushed
the
add-date-on-article-view
branch
from
7475777
to
e7732de
Compare
| {% else %} | ||
| {{ 'entry.list.reading_time_less_one_minute_short'|trans|raw }} | ||
| {% endif %} | ||
| </div> |
There was a problem hiding this comment.
We should display a real text for baggy because icons aren't displayed:
Instead of using icons (which aren't available) display real text for reading time & creation date
|
@tcitworld yeah but I don't know how to fix it.. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2034 (from @foxmask)