Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if asset is enable instead of opposite #2279

Merged
merged 4 commits into from
Sep 11, 2016
Merged

Check if asset is enable instead of opposite #2279

merged 4 commits into from
Sep 11, 2016

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Sep 9, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
Fixed tickets
License MIT

Instead of defining ASSETS all the time, just define it when we want to
use it
Might give us more clearer build
Since $ASSETS can be empty now and only be “build”.
Introduced in the recent 2.5.5 release.
Also updated deps.
It looks like when you clear entities on Postgres some references are lost and tags are not saved :-/
@j0k3r j0k3r added this to the 2.1.0 milestone Sep 11, 2016
@nicosomb
Copy link
Member

👍

@nicosomb nicosomb closed this Sep 11, 2016
@nicosomb nicosomb reopened this Sep 11, 2016
@nicosomb nicosomb merged commit 59758d8 into 2.1 Sep 11, 2016
@nicosomb nicosomb deleted the cleanup-travis branch September 11, 2016 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants