Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some checks about Redis & RabbitMQ #2306

Merged
merged 3 commits into from
Sep 25, 2016
Merged

Some checks about Redis & RabbitMQ #2306

merged 3 commits into from
Sep 25, 2016

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Sep 24, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation yes
Fixed tickets
License MIT
  • Disable PHPUnit deprecation that fail tests since Twig 1.25.0 (it didn't seems the error come from something we've done)
  • Display a message when async import won’t work
    Preview of the error message:
  • Avoid failing tests for user who didn’t install Redis (test will be marked as skip)

@j0k3r j0k3r added this to the 2.1.0 milestone Sep 24, 2016
@tcitworld
Copy link
Member

👍

@@ -16,6 +16,7 @@
<php>
<ini name="error_reporting" value="-1" />
<server name="KERNEL_DIR" value="app/" />
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to watch updates about this.

@tcitworld tcitworld merged commit 9d7dd6b into 2.1 Sep 25, 2016
@j0k3r j0k3r deleted the redis-rabbit-check branch September 25, 2016 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants