Show number of annotations instead of nbAnnotations placeholder #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there was more than one annotation, a placeholder was displayed in both themes, instead of actual number.
j0k3r
reviewed
Oct 9, 2016
| @@ -54,7 +54,6 @@ | |||
| {% endif %} | |||
| </i> | |||
|
|
|||
| {% set nbAnnotations = entry.annotations | length %} | |||
There was a problem hiding this comment.
Could you also remove that line in the material theme?
There was a problem hiding this comment.
That line was never added to the Material theme in a first place.
There was a problem hiding this comment.
I guess that's the origin of the issue.
There was a problem hiding this comment.
I tested both themes and this line was not helping in the baggy theme either – both themes showed a placeholder instead of the number of annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was more than one annotation, the
%nbAnnotations%placeholder was displayed in both themes, instead of actual number.