Search by term: extend to entries url #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
requested changes
Feb 3, 2017
|
|
||
| $form = $crawler->filter('form[name=search]')->form(); | ||
| $data = [ | ||
| 'search_entry[term]' => 'domain', // a string not available in the database |
There was a problem hiding this comment.
You might change the comment and maybe use a real domain name instead?
There was a problem hiding this comment.
Yes, I will update the comment to say that the filtering is not limited to domains but is applied to the whole url.
For the value used for the test, I took the value from testFilterOnDomainName.
|
The current change is expected to fail with PostgreSQL. It will help confirm if there is case sensitivity issue on the search part. |
Kdecherf
changed the title
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
|
Ready for review |
Kdecherf
changed the title
tcitworld
approved these changes
Feb 16, 2017
nicosomb
approved these changes
Feb 17, 2017
j0k3r
approved these changes
Feb 19, 2017
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends search to entries url to provide an alternative way to domain filtering.