Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share articles to a scuttle / semantic scuttle instance #2999

Merged
merged 2 commits into from Mar 28, 2017
Merged

Share articles to a scuttle / semantic scuttle instance #2999

merged 2 commits into from Mar 28, 2017

Conversation

FrenchHope
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? yes/no
Deprecations? yes/no
Tests pass? yes/no
Documentation yes/no
Translation yes/no
Fixed tickets #...
License MIT

nicosomb
nicosomb requested changes Mar 20, 2017
View reviewed changes
Copy link
Member

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

We need a database migration for this feature.

tests/Wallabag/ImportBundle/fixtures/wallabag-v1-read.json Outdated
@@ -5,14 +5,14 @@
"2": "https://www.wallabag.org/features/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a file used for tests, no need to edit it.

@nicosomb nicosomb added this to the 2.3.0 milestone Mar 20, 2017
@nicosomb nicosomb changed the base branch from master to 2.3 March 28, 2017 11:49
@j0k3r j0k3r changed the base branch from 2.3 to master March 28, 2017 12:16
@j0k3r j0k3r changed the base branch from master to 2.3 March 28, 2017 12:16
@nicosomb nicosomb merged commit f76bcf6 into wallabag:2.3 Mar 28, 2017
@nicosomb
Copy link
Member

Thank you @FrenchHope for your first contribution on wallabag 🍾 !

@j0k3r j0k3r mentioned this pull request Mar 28, 2017
Merged
@FrenchHope
Copy link
Contributor Author

Thank you @nicosomb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@tcitworld tcitworld tcitworld approved these changes

@j0k3r j0k3r Awaiting requested review from j0k3r

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FrenchHope @nicosomb @tcitworld