Added possibility to change locale from login/register pages #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicosomb
commented
Jun 12, 2017
•
nicosomb
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Documentation | no |
| Translation | no |
| Fixed tickets | #1695 |
| License | MIT |
- test ?
j0k3r
reviewed
Jun 18, 2017
| */ | ||
| public function setLocaleAction(Request $request, $language = null) | ||
| { | ||
| if ($language != null) { |
nicosomb
force-pushed
the
change-locale-register
branch
from
5afe60e
to
e4dcc1b
Compare
nicosomb
force-pushed
the
change-locale-register
branch
from
e4dcc1b
to
9d5f120
Compare
|
I rebased this PR. @j0k3r Do you think that we need test for this one? I can't test the language displayed on the login form because in our testsuite, we don't have language. |
|
Languages are hard coded in the HTML because we want the word in german, english and french (and not "Allemand, Anglais, Français" for example). |
j0k3r
force-pushed
the
change-locale-register
branch
from
9d5f120
to
17f120e
Compare
- Do not override locale if user has choosen a locale from the login screen. - Add some tests about locale url
j0k3r
force-pushed
the
change-locale-register
branch
from
17f120e
to
4d4147b
Compare
j0k3r
approved these changes
Oct 15, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.