Preview picture: use the 1st pic retrieved if no og:image set #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I switched the target branch to be the 2.4 (to avoid to much rebase before releasing it). About the work done, good job, it's an interesting feature. |
|
Great, I'll try to rebase it this week (There is no "rebase" button in Github?)! |
There is. But it's only displayed when the branch has conflicts with the target branch. Which isn't the case here. |
|
Rebased. I'll try to fix the existing tests now. |
|
Tests fixed :). |
|
You should run |
|
Sorry, I did not see the lint failing… |
j0k3r
approved these changes
May 24, 2019
tcitworld
approved these changes
May 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to have a preview picture for every link I add to my wallabag. Currently only pictures set as
og:imageare used for the preview picture (unless the link is an image).This MR parses the content to find the first picture in the content and use it as a preview (unless there already is a preview picture).
I'd like that to be added to the core but maybe you'd prefer if it required an activation from the user (a new boolean)? That's why I did not edit the tests that check there are no preview pictures for some links: I am waiting for your feedback.