Move Ignore Origin rules to database #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the need for RuleInterface? What do tagging rules and these origin rules have in common ? |
|
@tcitworld they have Config and Id getters and setters in common. Making an interface for these two entities makes me reuse |
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
1751fbb
to
143abe9
Compare
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
2 times, most recently
from
b1ab2ea
to
4a40fe8
Compare
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
4a40fe8
to
dd20c74
Compare
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
dd20c74
to
9e5a1f7
Compare
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
2 times, most recently
from
347ff08
to
6445179
Compare
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
6445179
to
254810f
Compare
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
254810f
to
695a9a8
Compare
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
695a9a8
to
a3c6ff4
Compare
|
This PR is finally ready for review, enjoy @wallabag/core |
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
2 times, most recently
from
361a189
to
125ec65
Compare
|
I will try the feature before merging it, ok? |
|
@nicosomb yeah sure, go on |
nicosomb
reviewed
Apr 18, 2020
nicosomb
requested changes
Apr 18, 2020
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
125ec65
to
84e316a
Compare
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
84e316a
to
773625e
Compare
|
@nicosomb did you test it? |
|
Yes. As I said on gitter, I think that explanations are not so clear but I don't see how we can improve them. |
nicosomb
previously approved these changes
Apr 24, 2020
Add IgnoreOriginUserRule for user-defined rules and IgnoreOriginInstanceRule for system-wide rules. Add an interface for these two new entities. Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
This commits adds a new helper like RuleBasedTagger for processing ignore origin rules. It also adds a new custom RulerZ operator for the '~' pattern matching rule. Renames 'pattern' with '_all' in IgnoreOriginRule entity. Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Excluding this group can decrease the run time of tests during development. Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Kdecherf
force-pushed
the
3760-ignorelist-db
branch
from
773625e
to
71f7e58
Compare
j0k3r
approved these changes
Apr 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3760