Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation of date in the footer using IntlDateFormatter #4971

Merged
merged 1 commit into from Jan 25, 2021
Merged

Fix translation of date in the footer using IntlDateFormatter #4971

merged 1 commit into from Jan 25, 2021

Conversation

Kdecherf
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass?
Documentation no
Translation no
CHANGELOG.md no
License MIT

Fixes #2476
Fixes #2870

@Kdecherf
Fix translation of date in the footer using IntlDateFormatter
ebda186 
Fixes #2476
Fixes #2870

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf Kdecherf added this to the 2.4.2 milestone Jan 24, 2021
j0k3r
j0k3r approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is smart, congrats! I wasn't aware of IntlDateFormatter!

@j0k3r j0k3r merged commit 8869c7a into master Jan 25, 2021
@j0k3r j0k3r deleted the fix/footer-date-translation branch January 25, 2021 08:33
@Kdecherf
Copy link
Member Author

This is smart, congrats! I wasn't aware of IntlDateFormatter!

Me neither, thanks to @aaa2000 for #2476 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

@nicosomb nicosomb Awaiting requested review from nicosomb

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

Error in cyrillic month Date not translated in the footer
2 participants
@Kdecherf @j0k3r