fix of _SESSION - indefined variable #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can freeze features for wallabag v1. But, I want to fix one last problem: cron and import. |
nicosomb
added a commit
that referenced
this pull request
Mar 19, 2014
fix of _SESSION - indefined variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will fix problem with undefined session variable.
I find, however, that our entire process of session handling is bad. For example, we try to logout user even if he is not logged in, logout is done via destroying of session and a lot of more small or larger bad ideas. Maybe it's now time to freeze list of features we want to add into v.1, do it all and concentrate on v.2.