New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove transitive dependencies #5784
Remove transitive dependencies #5784
Conversation
7a97124
to
4b02400
Compare
EDIT: no more dependency upgrade as it seems to break a test |
I just merged master into the 2.6.0 branch |
4b02400
to
216b5f1
Compare
Do we really need 22 commits for changing 2 files? |
@j0k3r "need" I would say no, I made it this way to isolate each update. |
@yguedidi you can squash all commits changing composer files, I'll merge after that |
216b5f1
to
e881b9d
Compare
@Kdecherf done |
Thanks @yguedidi 👍 |
Have the code rely on transitive dependencies (dependencies not explicitly required) is not good, as their versioning is not managed by us.
This PR remove relying on transitive dependencies by requiring them explicitly at their installed minor version from composer.lock.
Transitive dependencies are identified with ComposerRequireChecker
Here the result on current 2.6.0 branch (d510dc6):
Here the result after this PR:
Remaining unknown symbols are the ones: