Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Carrot & Scuttle share #6047

Merged
merged 2 commits into from Nov 3, 2022
Merged

Removed Carrot & Scuttle share #6047

merged 2 commits into from Nov 3, 2022

Conversation

nicosomb
Copy link
Member

@nicosomb nicosomb commented Nov 1, 2022 •
edited

Q A
Bug fix? no
Category? CO
Type? improvement
New feature? no
BC breaks? yes, kind of
Deprecations? no
Tests pass? yes
Documentation no
Translation yes
CHANGELOG.md no
License MIT

Carrot and Scuttle services are no longer available. No need to deprecate these services.

Less code, less bug.

@nicosomb nicosomb added this to the 2.6.0 milestone Nov 1, 2022
j0k3r
j0k3r requested changes Nov 2, 2022
View reviewed changes
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update our PR against the master and regenerate assets yarn build:prod ?

@nicosomb
Copy link
Member Author

nicosomb commented Nov 2, 2022

Oh, you want to release this in the next patch?

@j0k3r
Copy link
Member

j0k3r commented Nov 2, 2022

😆
Sorry, I'm a kind of bot ... I write master instead of 2.6.0 ...

@nicosomb
Copy link
Member Author

nicosomb commented Nov 2, 2022

😁
My PR seems up to date with 2.6.0 ...

@j0k3r
Copy link
Member

j0k3r commented Nov 2, 2022

Just rebuild assets then

@nicosomb
Copy link
Member Author

nicosomb commented Nov 2, 2022

I hope it will be ok.

@nicosomb
Copy link
Member Author

nicosomb commented Nov 2, 2022

I hope it will be ok.

Yes it is 🎉

@nicosomb nicosomb requested a review from j0k3r November 2, 2022 12:28
@j0k3r j0k3r merged commit d8584f6 into 2.6.0 Nov 3, 2022
@j0k3r j0k3r deleted the remove-useless-share-website branch November 3, 2022 08:01
@nicosomb nicosomb mentioned this pull request Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

@Kdecherf Kdecherf Awaiting requested review from Kdecherf

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicosomb @j0k3r