New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Swagger for api documentation #6062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
To run test: make test
Also, run CS-Fixer too: php bin/php-cs-fixer fix
src/Wallabag/CoreBundle/Command/SwaggerDocblockConvertCommand.php
Outdated
Show resolved
Hide resolved
I fixed the tests and ran the formatter. I added the _format parameter to the export call, however in this version of nelmio/api-doc the {_format} is always stripped of the path. Please see if this is acceptable. |
You mean, on the generated doc? |
Yes, in the generated doc the {_format} is always stripped for the path. That is hard coded in the nelmio code. |
What was that conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
We plan to upgrade to Symfony 4 later, so we'll update the bundle at that time. |
Convert ApiDoc to Swagger
Done |
I work on Read It Later wallabag client and I want better api documentation. I think the first step is updating nelmio/api-doc. This will bring an extended way to document the api.
This PR updates to nelmio/api-doc 3.0 and translates the existing documentation to the new format. I tried to keep the same content as the old api doc.
I have two outstanding issues:
{_format)
path parameters are not automatically shown in version 3.0. I don't see how this was added in the old version. Which api calls do have the format parameter? I assume this is only a subset of the calls, so want to add these manually.Makes progress on #2721