Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all Doctrine deps #6143

Merged
merged 1 commit into from Dec 16, 2022
Merged

Update all Doctrine deps #6143

merged 1 commit into from Dec 16, 2022

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Dec 14, 2022

⚠️ It needs #6136 to be merged first.

Also update these deps to be compatible with latest Doctrine version:

The PR is WIP because I can't generate a diff from the database:

In Exception.php line 112:

  Unknown column type "json_array" requested. Any Doctrine type that you use has to be registered with \Doctrine\DBAL\Types\Type::addType(). You can get a list of all the known types with \Doctrine\DBAL\Types\Type::getTypesMap(). If this error occurs during database introspection then you might have forgotten to register all database types for a Doctrine Type
  . Use AbstractPlatform#registerDoctrineTypeMapping() or have your custom types implement Type#getMappedDatabaseTypes(). If the type name is empty you might have a problem with the cache or forgot some mapping information.

I guess it might be because of other deps not yet updated. We'll see later.

@j0k3r
Copy link
Member Author

j0k3r commented Dec 15, 2022

I've created a separate issue (#6149) about the json_array field type to avoid blocking the update (because other ones depends on it).

nicosomb
nicosomb previously approved these changes Dec 15, 2022
Copy link
Member

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok and testsuite is green.

composer.json Outdated Show resolved Hide resolved
Also update these deps to be compatible with latest Doctrine version:
- `friendsofsymfony/oauth-server-bundle`
- `lexik/form-filter-bundle`
- `dama/doctrine-test-bundle`
@j0k3r j0k3r merged commit ef83032 into master Dec 16, 2022
@j0k3r j0k3r deleted the fix/update-doctrine branch December 16, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants