New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all Doctrine deps #6143
Merged
Merged
Update all Doctrine deps #6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
force-pushed
the
fix/update-doctrine
branch
from
December 14, 2022 13:49
47bf680
to
d639afa
Compare
Merged
j0k3r
force-pushed
the
fix/update-doctrine
branch
from
December 15, 2022 08:16
88fbf94
to
9577038
Compare
I've created a separate issue (#6149) about the |
j0k3r
force-pushed
the
fix/update-doctrine
branch
from
December 15, 2022 08:26
9577038
to
63ecff6
Compare
nicosomb
previously approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok and testsuite is green.
j0k3r
force-pushed
the
fix/update-doctrine
branch
2 times, most recently
from
December 15, 2022 14:40
41821c6
to
d05f158
Compare
Kdecherf
force-pushed
the
fix/update-doctrine
branch
from
December 15, 2022 22:54
d05f158
to
fa3c02e
Compare
Kdecherf
reviewed
Dec 15, 2022
j0k3r
force-pushed
the
fix/update-doctrine
branch
from
December 16, 2022 09:10
fa3c02e
to
50bffb3
Compare
Also update these deps to be compatible with latest Doctrine version: - `friendsofsymfony/oauth-server-bundle` - `lexik/form-filter-bundle` - `dama/doctrine-test-bundle`
j0k3r
force-pushed
the
fix/update-doctrine
branch
from
December 16, 2022 09:30
50bffb3
to
b3099f6
Compare
Kdecherf
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update these deps to be compatible with latest Doctrine version:
friendsofsymfony/oauth-server-bundle
lexik/form-filter-bundle
dama/doctrine-test-bundle
(but there are issue about rollbacking in some cases Syntax error or access violation: 1305 SAVEPOINT DOCTRINE2_SAVEPOINT_2 does not exist dmaicher/doctrine-test-bundle#58)The PR is WIP because I can't generate a diff from the database:
I guess it might be because of other deps not yet updated. We'll see later.