Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventDispatcher & events #6154

Merged
merged 1 commit into from Dec 16, 2022
Merged

Fix EventDispatcher & events #6154

merged 1 commit into from Dec 16, 2022

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Dec 15, 2022

Looks like parameter for the ->dispatch( have been flipped (event first then event name). Define events should now extends Symfony\Contracts\EventDispatcher\Event

Looks like parameter for the `->dispatch(` have been flipped (event first then event name).
Define events should now extends `Symfony\Contracts\EventDispatcher\Event`
@j0k3r j0k3r added this to the 2.6.0 milestone Dec 15, 2022
@j0k3r j0k3r changed the title Fix EventDispatcer & events Fix EventDispatcher & events Dec 15, 2022
Copy link
Member

@Kdecherf Kdecherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nicosomb nicosomb merged commit 9c16dd7 into master Dec 16, 2022
@nicosomb nicosomb deleted the fix/event-dispatcher branch December 16, 2022 07:08
@nicosomb
Copy link
Member

Thank you @j0k3r !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants