fix for config links #6256
Merged
fix for config links #6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j0k3r didn't see any other areas in config where this could be applicable. |
tcitworld
reviewed
Jan 24, 2023
| @@ -45,7 +45,7 @@ | |||
| {{ form_label(form.config.reading_speed) }} | |||
| <p> | |||
| {{ 'config.form_settings.reading_speed.help_message'|trans }} | |||
| <a href="https://wallabag.github.io/myreadspeed/">myreadspeed</a> | |||
| <a target="_blank" href="https://wallabag.github.io/myreadspeed/">myreadspeed</a> | |||
There was a problem hiding this comment.
rel="noopener noreferrer" would have been nice.
There was a problem hiding this comment.
:( now u tell me
|
Just a little post, I'm not fan of |
|
@nicosomb what's the better way |
|
The better way is to let the user decide. |
|
@nicosomb The change is not in the article body, just in two links in the config section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #5400