Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] round reading time in export #6545

Merged
merged 1 commit into from May 24, 2023
Merged

Conversation

mart-e
Copy link
Contributor

@mart-e mart-e commented May 24, 2023

Before this commit, the exported entry (pdf, epub,...) could look like:

Estimated reading time:
2.6666666666667 min

Now it will be:

Estimated reading time
3 min

Screenshot from 2023-05-24 17-08-32

Q A
Bug fix? yes
New feature? no
BC breaks? ?
Deprecations? no
Tests pass? 馃
Documentation no
Translation no
CHANGELOG.md no
License MIT

Before this commit, the exported entry (pdf, epub,...) could look like:

Estimated reading time:
2.6666666666667 min

Now it will be:
Estimated reading time
3 min
@mart-e mart-e marked this pull request as ready for review May 24, 2023 15:08
@mart-e mart-e changed the title [FIX] round reading time in exporrt [FIX] round reading time in export May 24, 2023
@j0k3r j0k3r added the feat: export Issues and pull requests related to the export feature label May 24, 2023
@j0k3r j0k3r added this to the 2.6.0 milestone May 24, 2023
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, same behavior as in the Twig template 馃憤

@j0k3r j0k3r merged commit 550639b into wallabag:master May 24, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: export Issues and pull requests related to the export feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants