Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autoload fixtures #6648

Merged
merged 1 commit into from Jun 20, 2023
Merged

Do not autoload fixtures #6648

merged 1 commit into from Jun 20, 2023

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Jun 20, 2023

They should only be loaded from app/config/services_test.yml (they are already loaded from there). Otherwise we'll have an issue when clearing the cache in prod env:

In DefinitionErrorExceptionPass.php line 54:

  Class "Doctrine\Bundle\FixturesBundle\Fixture" not found while loading "Wal
  labag\AnnotationBundle\DataFixtures\AnnotationFixtures".

Also update deps to latest.
Fix #6647

They should only be loaded from `app/config/services_test.yml`.
Otherwise we'll have an issue when clearing the cache in prod env:

```
In DefinitionErrorExceptionPass.php line 54:

  Class "Doctrine\Bundle\FixturesBundle\Fixture" not found while loading "Wal
  labag\AnnotationBundle\DataFixtures\AnnotationFixtures".
```

Also update deps to latest.
@j0k3r j0k3r added this to the 2.6.1 milestone Jun 20, 2023
@j0k3r j0k3r requested review from nicosomb and Kdecherf June 20, 2023 17:29
@nicosomb nicosomb enabled auto-merge June 20, 2023 17:36
@nicosomb nicosomb merged commit 4d52e6f into master Jun 20, 2023
16 checks passed
@nicosomb nicosomb deleted the fix/dont-autoload-fixtures branch June 20, 2023 17:52
@jason-weiser
Copy link

Hi! Thanks for all the work you all do on this project. I'm just writing because I ran "make update" on my current installation and it appears to be broken with the error referenced above:

`In DefinitionErrorExceptionPass.php line 54:

Class "Doctrine\Bundle\FixturesBundle\Fixture" not found while loading "Wal
labag\AnnotationBundle\DataFixtures\AnnotationFixtures".

Script bin/console cache:clear --no-warmup handling the post-cmd event returned with error code 1
Script @post-cmd was called via post-install-cmd`

This appears to be closed, but how do I go about un-breaking my install?

Thanks for any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make: *** [GNUmakefile:24: update] Error 1
3 participants