Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep escaped table name while migrating #6710

Merged
merged 1 commit into from Jul 17, 2023
Merged

Conversation

Glandos
Copy link
Contributor

@Glandos Glandos commented Jul 9, 2023

Q A
Bug fix? yes
New feature? o
BC breaks? no
Deprecations? no
Tests pass? yes/no
Documentation no
Translation no
CHANGELOG.md no
License MIT

Fix #6709

I don't now if this change will fit with MySQL.

@nicosomb
Copy link
Member

Hello @Glandos. Thank you for your pull request.
Is that necessary to update all the database migrations files?

@Glandos
Copy link
Contributor Author

Glandos commented Jul 10, 2023

Hmm, I don't know, since I was just upgrading from 2.5.x to 2.6.1, only this one was applied.
But my best guess is that yes, it's better to escape table name everywhere. However, testing for this is … tedious.

Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
I'm in the process of adding build to the CI so that we are actually testing wallabag when no database table prefix are defined.

@j0k3r j0k3r added this to the 2.6.2 milestone Jul 17, 2023
@j0k3r j0k3r merged commit df56bfe into wallabag:master Jul 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty db_table_prefix with postgresql and user table must be escaped
3 participants