Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing randomly test #6763

Merged
merged 1 commit into from Jul 27, 2023
Merged

Fix failing randomly test #6763

merged 1 commit into from Jul 27, 2023

Conversation

nicosomb
Copy link
Member

@nicosomb nicosomb commented Jul 26, 2023 •
edited

Q A
Bug fix? yes 馃
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes 馃
Documentation no
Translation no
CHANGELOG.md no
License MIT

We need to persist object and add a sleep call to be sure that the 2 objects have different updatedAt values.

In fact, in this test, $day3 and $day4 are useless because these dates are not keeped: as we persist objects, the updatedAt field is updated with current date.

@j0k3r j0k3r changed the title Try to fix failing randomly test Fix failing randomly test Jul 27, 2023
@nicosomb nicosomb added this to the 2.6.3 milestone Jul 27, 2023
@nicosomb nicosomb merged commit 911e023 into master Jul 27, 2023
19 checks passed
@nicosomb nicosomb deleted the fix-ci branch July 27, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicosomb @j0k3r