Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external dependencies on howto page #6775

Merged
merged 3 commits into from Aug 2, 2023
Merged

Remove external dependencies on howto page #6775

merged 3 commits into from Aug 2, 2023

Conversation

viktoriussuwandi
Copy link
Contributor

…ws/Developer/howto_app.html.twig

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Documentation no
Translation no
CHANGELOG.md no
License MIT

Fixes #6772

Hi nicosomb,
just trying to help on this issue, please check it out

Remove external dependencies on src/Wallabag/CoreBundle/Resources/views/Developer/howto_app.html.twig

@nicosomb
Copy link
Member

nicosomb commented Jul 30, 2023

Thank you @viktoriussuwandi.

Here is the screenshot before this PR

Capture d’écran 2023-07-30 à 10 08 01

Here is the screenshot with the PR

No need to embed an external dependency only for this section of wallabag.

Capture d’écran 2023-07-30 à 10 06 22

I also pushed a commit to replace hardcoded URL.

@nicosomb nicosomb added this to the 2.6.3 milestone Jul 30, 2023
@nicosomb nicosomb requested review from j0k3r and Kdecherf July 30, 2023 08:10
@Kdecherf Kdecherf merged commit 8281920 into wallabag:master Aug 2, 2023
19 checks passed
@viktoriussuwandi viktoriussuwandi deleted the issue#6772 branch August 3, 2023 05:16
@nicosomb nicosomb changed the title Remove external dependencies on src/Wallabag/CoreBundle/Resources/vie… Remove external dependencies on howto page Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove external dependencies
3 participants