Use Twig instead of templating #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguedidi
commented
Aug 5, 2023
|
|
||
| // For error pages, try to find a template for the specific HTTP status code and format | ||
| if (!$showException) { | ||
| $template = sprintf('@WallabagCore/Exception/%s.%s.twig', $name, $format); |
There was a problem hiding this comment.
this was the only difference from the base one, so now the base error template is moved to use the official way of overriding a template from a bundle
yguedidi
commented
Aug 5, 2023
| param_fetcher_listener: true | ||
| body_listener: true | ||
| exception: | ||
| serializer_error_renderer: true |
There was a problem hiding this comment.
this is needed so that exceptions thrown manually in rest controllers like in https://github.com/wallabag/wallabag/blob/master/src/Wallabag/ApiBundle/Controller/EntryRestController.php#L313 respond with JSON instead of HTML
yguedidi
commented
Aug 5, 2023
Comment on lines
+87
to
+89
| zone: | ||
| - { path: ^/api } | ||
| - { path: ^/annotations } |
There was a problem hiding this comment.
added because of the addition of serializer_error_renderer
yguedidi
commented
Aug 5, 2023
| @@ -117,9 +119,6 @@ fos_rest: | |||
| - { path: "^/api/entries/([0-9]+)/export.(.*)", priorities: ['epub', 'mobi', 'pdf', 'txt', 'csv'], fallback_format: json, prefer_extension: false } | |||
| - { path: "^/api", priorities: ['json', 'xml'], fallback_format: json, prefer_extension: false } | |||
| - { path: "^/annotations", priorities: ['json', 'xml'], fallback_format: json, prefer_extension: false } | |||
| # for an unknown reason, EACH REQUEST goes to FOS\RestBundle\EventListener\FormatListener | |||
| # so we need to add custom rule for custom api export but also for all other routes of the application... | |||
There was a problem hiding this comment.
not sure about the "for custom api export" part here
Kdecherf
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from https://github.com/symfony/symfony/blob/4.4/UPGRADE-5.0.md#frameworkbundle
remove ~1180 direct depreciation, see from 2119 to 940 for example