Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify platforms by their class #6799

Merged
merged 1 commit into from Aug 8, 2023
Merged

Identify platforms by their class #6799

merged 1 commit into from Aug 8, 2023

Conversation

yguedidi
Copy link
Contributor

@yguedidi yguedidi commented Aug 5, 2023 •
edited

Relying on the name of the platform is discouraged. To identify the platform, use its class name.

from https://github.com/doctrine/dbal/blob/3.6.x/UPGRADE.md#deprecated-abstractplatformgetname

remove ~177 direct depreciation, see from 2119 to 1942 for example

@Kdecherf Kdecherf added this to the 2.6.3 milestone Aug 8, 2023
@Kdecherf Kdecherf merged commit f6e85e8 into wallabag:master Aug 8, 2023
19 checks passed
@yguedidi yguedidi deleted the identify-platforms-by-their-class branch August 8, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kdecherf Kdecherf Kdecherf approved these changes

@j0k3r j0k3r Awaiting requested review from j0k3r

@nicosomb nicosomb Awaiting requested review from nicosomb

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yguedidi @Kdecherf