Feat/domain status filters html types #6888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Simounet could you please fix your PR with php cs ? |
Simounet
force-pushed
the
feat/domain-status-filters-html-types
branch
from
3eb49fd
to
93ac1d3
Compare
|
Shouldn't we target 2.6.5 for that? |
|
I'll change the branch and push again. |
Simounet
force-pushed
the
feat/domain-status-filters-html-types
branch
from
93ac1d3
to
30dd155
Compare
|
Working with everything but PHP7.4. Any clues? |
|
Maybe be cause of |
|
It fails before that test and only with 7.4. 😢 |
|
I've tested locally on PHP 7.4 and got: |
Simounet
force-pushed
the
feat/domain-status-filters-html-types
branch
from
30dd155
to
5c30dfc
Compare
Simounet
force-pushed
the
feat/domain-status-filters-html-types
branch
from
5c30dfc
to
97d2a53
Compare
|
Working when value cast as an integer. |
|
PHP 8.x is more restrictive for that. |
|
Yep, I was expecting the opposite. Working on 7.x and not working on 8+. Glad to see it working anyway. |
j0k3r
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the types and accepted values for status and domain filters (right column). Better for mobile inputs.