Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance on homepage #6909

Merged
merged 3 commits into from Sep 1, 2023
Merged

Conversation

Simounet
Copy link
Member

@Simounet Simounet commented Aug 31, 2023

Some optimisations mostly for the homepage. Started from a ~600ms response to a ~260ms one with 16.5k entries and A LOT of untagged entries.

  • removed useless title on the footer's stats (called twice)
  • untagged entries counter removed (there is no counters on other entries, we should treat it like a classic filter)
  • SQL count simplification (not sure about this one because of the Postgres comment you left but it was from 2016 and I'm not using a column in COUNT())

@Simounet
Copy link
Member Author

I have to find a solution for Postgres. 😅

@nicosomb
Copy link
Member

The 2 first changes are ok for me.

About the last one, I don't understand why we have so many failing tests ...

@Simounet Simounet force-pushed the feat/homepage-perfs branch 2 times, most recently from be21155 to bb3ab6e Compare August 31, 2023 12:58
@Kdecherf Kdecherf self-requested a review August 31, 2023 13:07
@nicosomb nicosomb changed the title Feat/homepage perfs Improve performance on homepage Aug 31, 2023
@Simounet Simounet force-pushed the feat/homepage-perfs branch 2 times, most recently from bb3ab6e to c1334d2 Compare September 1, 2023 09:40
@Simounet
Copy link
Member Author

Simounet commented Sep 1, 2023

It's working with separated methods just for COUNT purpose, not using GROUP BY.

@j0k3r j0k3r added this to the 2.6.6 milestone Sep 1, 2023
Copy link
Member

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nicosomb nicosomb merged commit dbed27f into wallabag:2.6 Sep 1, 2023
19 checks passed
@Simounet Simounet deleted the feat/homepage-perfs branch September 1, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants