Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epub is here ! #691

Merged
merged 9 commits into from
May 18, 2014
Merged

Epub is here ! #691

merged 9 commits into from
May 18, 2014

Conversation

tcitworld
Copy link
Member

No description provided.

@nicosomb
Copy link
Member

Great. I'll try to try it today.

@nicosomb
Copy link
Member

Yeah, it works fine :)
Some questions:

  • why table of contents if at the end of the epub?
  • is that possible to have a different name for each epub?

@tcitworld
Copy link
Member Author

  • well that how the Library I use does it, but I'll try to put it front. If you un-comment line 1219 from poche.inc.php you'll see another table of content on front of the epub, supposed to be epub3 compliant, but I find it strange. You can test it.
  • Sure, based on what ? Something like my $bookTitle variable ?

Note : Ebooks should be epub3 compliant, errors with validator can happen if the wallabaged page isn't made with good html. Metadata seems also not recognised, but I don't think this will bring problems.

@nicosomb
Copy link
Member

  • I'll look
  • I downloaded 2 epub ... and it's confusing and not easy to open the good file ;)

@tcitworld
Copy link
Member Author

Yeah, I agree with you on the naming issue, I was just asking what you would like it to be. ;)

@nicosomb
Copy link
Member

OK, the title of the article or the domain name, or anything else, I don't know ...

@tcitworld
Copy link
Member Author

And in case of multiple articles, the title from the first one ?

@nicosomb
Copy link
Member

How can you download multiple articles?

@tcitworld
Copy link
Member Author

From the categories, the tags, the search page or even the config page :)

@nicosomb
Copy link
Member

Argh, I can't try this feature... I merged your other PR, and now, I've some conflicts.
For next PR, can you create one branch per feature (with a different name) please?

Edit: I don't think it's the problem ... but I think it's easier with one branch per feature.

@nicosomb
Copy link
Member

And in case of multiple articles, the title from the first one ?

I don't think it's the good way. It can be confusing.
Today (Category home.epub for example), it's good for me.

Good job :)

@tcitworld
Copy link
Member Author

For next PR, can you create one branch per feature (with a different name) please?

Yup, sorry for the inconvenient. What are the conflicts ? I can try to pull dev branch into this one if needed.

@tcitworld tcitworld merged commit f3f0b11 into wallabag:dev May 18, 2014
@aschilling
Copy link

Thanks for implementing ePub support. Do you think you can also add .mobi support for reading on a Kindle?

@tcitworld
Copy link
Member Author

Not for now but if I found a library which handles it easily I may add it some day.
However you can try converting with Calibre your file. I would also take a look at the service @fivefilters provide : push to kindle

@aschilling
Copy link

Thanks, I did some research and found this project https://github.com/raiju/phpMobi maybe you can have a look at it. The main benefit of having a self-contained mobi generation in wallabag in my opinion is to minimize third-party configuration and requirements for new users

@tcitworld
Copy link
Member Author

Seems interesting. Could you open a new issue specific to mobi export, so that I don't forget it in one hour ? Thank you in advance.

@tcitworld tcitworld deleted the epub branch May 20, 2014 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants