Mass action layout improved #6912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
previously approved these changes
Sep 1, 2023
Simounet
force-pushed
the
feat/tag-mass-action-improved
branch
from
02fa956
to
36b134f
Compare
|
I'm sorry but I lost your approval after updating the code for using the color variable. |
|
A :) |
j0k3r
previously approved these changes
Sep 4, 2023
Simounet
force-pushed
the
feat/tag-mass-action-improved
branch
from
36b134f
to
4b04cd5
Compare
nicosomb
approved these changes
Sep 4, 2023
j0k3r
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements for the main top parts of the homepage. More mobile friendly and less clicks for adding tags. Should fix #6818 by removing the click on the tag before being able to submit the form. I'm not sure if it's better with the icon before or after the input. Visually better with the icon before but I think the user flow is better with the icon after.
A.
B.
Before
After