Update deps & Node 20 #7134
Merged
Update deps & Node 20 #7134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly to free `symfony/phpunit-bridge`. Also raise minimum version of node to 20, v16 is unmaintained since October 2023.
nicosomb
approved these changes
Dec 22, 2023
Merged
Merged
|
Going through the release notes, I found this... Does that mean Wallabag (now ?) required NodeJS to be installed in addition to php ? 🤔 |
|
Not at all. We are using Node to build assets, once they are built, you don't need Node anymore. Otherwise, assets are built during the packaging of wallabag. So end user, don't need Node to run wallabag. |
|
Great, thanks for the explanation. So nothing to change on Yunohost side, that's handy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to free
symfony/phpunit-bridge.Also raise minimum version of node to 20, v16 is unmaintained since October 2023.