Use IsGranted in EntryController #7375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
yguedidi
force-pushed
the
use-isgranted-in-entrycontroller
branch
2 times, most recently
from
bb23764
to
ca7ee81
Compare
|
Thanks @j0k3r! squashing to a single commit before merging |
yguedidi
force-pushed
the
use-isgranted-in-entrycontroller
branch
from
ca7ee81
to
e66ea21
Compare
j0k3r
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better reviewed commit by commit.
Left as a draft PR so that it's not accidentaly merged before squashing in one commit after approve :)
For EntryVoter, all attributes are using the same rule: being the user of the entry.
But because it's about security, I prefered to be as granular as possible, in case each actions grant rules change in the future.
That's why I added an attribute per action, and updated the templates accordingly.
Same for MainVoter, that will own general actions not on a particular subject.
Just used the same LIST_ENTRIES for all entries listing actions as each is just a specific filtering.