Proposed fix for #773 #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.php takes care of stuff like the PHP version and is executed before the config files are included which are needed by check_setup. This patch addresses issue #773
| // Check if /cache is writeable | ||
| if (! is_writable('cache')) { | ||
| die('The directory "cache" must be writeable by your web server user'); | ||
| } | ||
|
|
||
| // Check if /db is writeable | ||
| if (! is_writable('db')) { | ||
| if (! is_writable('db') && STORAGE === 'sqlite') { |
There was a problem hiding this comment.
Just to be sure, if we choose mysql or postgres on install screen, no worry with this line?
There was a problem hiding this comment.
Yes. I've tested it with mysql and sqlite. Did behave as it should. The only time this may be problematic is if another file based database would be added. Then this would need to be extended by another statement or converted into a regex.
There was a problem hiding this comment.
Great. I'll try your PR and merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up check_setup.php into two files. The new file check_essentials.php takes care of stuff like the PHP version and is executed before the config files are included which are needed by check_setup. This patch addresses issue #773