Making the close button more visually consistent on the menu popup forms #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With your PR, we now have a difference between the search popup and the save a link popup. |
|
Sorry, I don't understand? On Thu, Oct 30, 2014 at 4:17 PM, Nicolas Lœuillet notifications@github.com
|
|
Have a look to the 2 popups: the close button is different. They have to be equal. |
|
In fact, there were already different ... I don't know you want to do this change. |
|
Strange, they look the same to me. Is your cache cleared?
|
|
Wow, sorry, I forgot to clear my cache. |
nicosomb
added a commit
that referenced
this pull request
Oct 30, 2014
Making the close button more visually consistent on the menu popup forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.