Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many small UI changes/fixes to Baggy theme and English translation files #920

Merged
merged 7 commits into from
Nov 3, 2014

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Nov 2, 2014

Many small UI changes/fixes to Baggy theme and English translation files. May need review.

@@ -83,30 +84,9 @@
<input type="hidden" name="token" value="{{ token }}">
</form>

{% if http_auth == 0 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove "change password" form?

@nicosomb
Copy link
Member

nicosomb commented Nov 3, 2014

all seems fine for me, unless the change password form.

@nicosomb
Copy link
Member

nicosomb commented Nov 3, 2014

other question for all your PR's: can you have a look to the 'default' theme and make some changes if necessary please?

@jsit
Copy link
Contributor Author

jsit commented Nov 3, 2014

My mistake on the password form; I meant to put it closer to the bottom of the page (where the more "admin"-oriented stuff, I think, should be positioned), but it looks like I removed it entirely. Just pushed a fix for that.

@jsit
Copy link
Contributor Author

jsit commented Nov 3, 2014

Re: the "default" theme, I had kind of assumed that that was being retired in favor of Baggy. I'll see about applying these changes there as well.

I wonder if it wouldn't make more sense to have the themes only apply CSS/JS, and to use the same template files in all themes?

nicosomb added a commit that referenced this pull request Nov 3, 2014
Many small UI changes/fixes to Baggy theme and English translation files
@nicosomb nicosomb merged commit 3eba753 into wallabag:dev Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants