Skip to content

Commit

Permalink
Use chrome runner by default.
Browse files Browse the repository at this point in the history
  • Loading branch information
ArtemGovorov committed Sep 19, 2018
1 parent 6a312a8 commit 4ec776c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -8,9 +8,9 @@
- Exclude the [`src/wallabyTest.ts` file in the `tsconfig.json`](https://github.com/wallabyjs/ngCliWebpackSample/blob/82d4f43d1a1e701de403a2cdb38986bfb4ddca0b/src/tsconfig.app.json#L20) as it may affect [Angular AOT compilation](https://github.com/angular/angular/issues/13624#issuecomment-281919940).
- Run `npm install wallaby-webpack angular2-template-loader electron --save-dev`.

Note that the sample is [using Electron test runner](https://wallabyjs.com/docs/integration/electron.html).
Note that the sample is [using Chrome (headless) runner](https://wallabyjs.com/docs/integration/chrome.html).

Alternatively, you may use [Chrome (headless) runner](https://wallabyjs.com/docs/integration/chrome.html). In this case you may [change the `env` setting](https://github.com/wallabyjs/ngCliWebpackSample/blob/88a13b2c25f8808f733ec7cb058544f887f40190/wallaby.js#L49) to `env: {kind: 'chrome'}`, and you will not need to `npm i electron` (and can remove `electron` from the `package.json` dependencies).
Alternatively, you may use [Electron test runner](https://wallabyjs.com/docs/integration/electron.html). In this case you may [change the `env` setting](https://github.com/wallabyjs/ngCliWebpackSample/blob/88a13b2c25f8808f733ec7cb058544f887f40190/wallaby.js#L49) to `env: {kind: 'electron'}`, and run `npm i electron --save-dev`.

You may use PhantomJs runner if you like, to do that you may [remove the `env` setting](https://github.com/wallabyjs/ngCliWebpackSample/blob/88a13b2c25f8808f733ec7cb058544f887f40190/wallaby.js#L49). In this case, you will not need to `npm i electron` (and can remove `electron` from the `package.json` dependencies), however will need to uncomment [core-js polyfills](https://github.com/wallabyjs/ngCliWebpackSample/blob/88a13b2c25f8808f733ec7cb058544f887f40190/src/polyfills.ts#L23-L34) and [`Intl` polyfill](https://github.com/wallabyjs/ngCliWebpackSample/blob/88a13b2c25f8808f733ec7cb058544f887f40190/src/polyfills.ts#L68), so that PhantomJs may work.

Expand Down
1 change: 0 additions & 1 deletion package.json
Expand Up @@ -34,7 +34,6 @@
"@types/node": "~8.9.4",
"angular2-template-loader": "^0.6.2",
"codelyzer": "~4.3.0",
"electron": "^1.7.11",
"jasmine-core": "~2.99.1",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion wallaby.js
Expand Up @@ -69,7 +69,7 @@ module.exports = function (wallaby) {
},

env: {
kind: 'electron'
kind: 'chrome'
},

postprocessor: webpackPostprocessor,
Expand Down

0 comments on commit 4ec776c

Please sign in to comment.