Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in typescript file trigger wallaby but it doesn't detect changes #1404

Closed
rdkleine opened this issue Nov 22, 2017 · 2 comments
Closed
Labels

Comments

@rdkleine
Copy link

rdkleine commented Nov 22, 2017

Issue description or question

When Wallaby is running I'm changing my Typescript code (NOT the specs there it seems to work as intended). Wallaby detects that the file is changed and runs although the changes aren't compiled it seems because my test is still failing.
When I stop and start Wallaby the test succeeds.

wallaby

Wallaby.js configuration file

var wallabify = require('wallabify');
var wallabyPostprocessor = wallabify({
    // browserify options, such as
    // insertGlobals: false
  }
  // you may also pass an initializer function to chain other
  // browserify options, such as transformers
  // , b => b.exclude('mkdirp').transform(require('babelify'))
);

module.exports = function (wallaby) {
    return {
        files: [
            { pattern: './bower_components/jquery/dist/jquery.js', instrument: false },
            { pattern: './node_modules/phantomjs-polyfill/bind-polyfill.js', instrument: false },
            { pattern: './node_modules/jasmine-jquery/lib/jasmine-jquery.js', instrument: false },
            { pattern: './bower_components/angular/angular.js', instrument: false },
            { pattern: './node_modules/angular-mocks/angular-mocks.js', instrument: false },
            { pattern: './bower_components/angular-ui-router/release/angular-ui-router.min.js', instrument: false },
            { pattern: './bower_components/lodash/dist/lodash.min.js', instrument: false },
            { pattern: './bower_components/moment/moment.js', instrument: false },
            { pattern: 'App/azure-theme-ts/**/*.ts', load: false },
            { pattern: 'App/azure-theme-ts/**/*@(specs|Specs).ts', ignore: true }
        ],
        tests: [
            { pattern: 'App/azure-theme-ts/**/*@(specs|Specs).ts', load: false }
        ],
         postprocessor: wallabyPostprocessor,
        setup: function () {
            window.__moduleBundler.loadTests();
        },
        debug: true
    };
};

TsConfig

{
  "compilerOptions": {
    "target": "ES5",
    "module": "commonjs",
    "noImplicitAny": true,
    "allowUnreachableCode": false,
    "noImplicitReturns": true,
    "noUnusedLocals": true
  }
}

Code editor or IDE name and version

Visual Studio Code v1.18.0

OS name and version

Windows 10

Debug log

​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:fs File changed in editor: App/azure-theme-ts/filters/filters.ts
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project File App/azure-theme-ts/filters/filters.ts changes are patches only: true
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Returning previously cached file [10] from memory
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Preparing to process App/azure-theme-ts/filters/filters.ts
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project No compilers configured for App/azure-theme-ts/filters/filters.ts
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project File App/azure-theme-ts/filters/filters.ts is not instrumented by core
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project No preprocessors configured for App/azure-theme-ts/filters/filters.ts
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Writing to disk and caching processed file App/azure-theme-ts/filters/filters.ts
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project File App/azure-theme-ts/filters/filters.ts changes saved, store ts: 1511356858960, change ts: 1511357132480
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Running postprocessor
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:testTask Test files from affected: 1, from deleted or manually requested: 0, from recently changed: 0, from loaded by: 0, from failing: 1
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Preparing to process App/azure-theme-ts/filters/filters.js
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Processing compiled App/azure-theme-ts/filters/filters.js
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Instrumenting App/azure-theme-ts/filters/filters.js, via process pool: false
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project No preprocessors configured for App/azure-theme-ts/filters/filters.js
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Writing to disk and caching processed file App/azure-theme-ts/filters/filters.js
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:uiService Outgoing message ui:files
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:postprocessor Emitting 1 files
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Postprocessor execution finished
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:project Test run started; run priority: 2
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:testTask Test files from affected: 1, from deleted or manually requested: 0, from recently changed: 0, from loaded by: 0, from failing: 1
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:workers Starting test run, priority: 2
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:phantomRunner Starting sandbox [worker #0, session #tjzuw]
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:phantomRunner Preparing sandbox [worker #0, session #tjzuw]
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:browserRunner Total files to load in sandbox: 10
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:browserRunner Sandbox is generated [worker #0, session #tjzuw]: http://localhost:53025/wallaby_sandbox0.html
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:phantomRunner Creating page for worker #0
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:phantomRunner Phantom page created
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:phantomRunner Prepared sandbox [worker #0, session #tjzuw]
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:workers [worker #0, session #tjzuw] Running tests in sandbox
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:middleware Preparing to serve /App/azure-theme-ts/filters/filters.js.bro.js
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:32 GMT wallaby:middleware Serving /App/azure-theme-ts/filters/filters.js.bro.js from cache
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:workers [tjzuw] Loaded 4 test(s)
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:workers [tjzuw] Test executed: should return programmes met subprogramms with tracks equal to one of the filterred tracks
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:workers [tjzuw] Run 1 test(s), skipped 3 test(s)
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:workers [tjzuw] Sandbox is responsive, closing it
​​​​​[Info]​​​​​ Finished executing 1 affected test(s)
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:project Test run finished
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:project Processed console.log entries
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:project Processed loading sequences
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:project Processed executed tests
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:project Processed code coverage
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:project Test run result processed and sent to IDE
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:uiService Outgoing message ui:summary
​​​​​[Info]​​​​​ Wed, 22 Nov 2017 13:25:33 GMT wallaby:uiService Outgoing message ui:tests:someResultsUpdated
@ArtemGovorov
Copy link
Member

Thanks for the detailed report. The issue is fixed and the fix is published in the latest core v1.0.251.

@rdkleine
Copy link
Author

Superfast! Thank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants