Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support passing license to VS Code Remote Container Instances #2937

Closed
Noriller opened this issue Feb 23, 2022 · 5 comments
Closed

Comments

@Noriller
Copy link

I've tried using devcontainers on vscode and saw that it needs to run in the container so you need to either add the license or do like the tutorial: https://wallabyjs.com/docs/intro/get-started-vscode.html#remote-containers

since there are extensions that run in the "main" vscode and others that run remote, and I don't know if it would work, wouldn't an extension that "prefers" to work on the main vscode be able to fix having to change the containers?

Could also add to that some easy place to change some options and config (both wallaby and quokka)

@smcenlly
Copy link
Member

Since there are extensions that run in the "main" vscode and others that run remote, and I don't know if it would work, wouldn't an extension that "prefers" to work on the main vscode be able to fix having to change the containers?

Unfortunately Wallaby/Quokka need to run in the container


I'll update the issue title as a feature request to support passing license to remote-container instances (we're not sure if this is technically possible).

@smcenlly smcenlly changed the title Suggestion: an "external" extension to hold license and maybe easy access to configurations Feature Request: Support passing license to VS Code Remote Container Instances Feb 23, 2022
@Noriller
Copy link
Author

Noriller commented Feb 23, 2022 via email

@smcenlly
Copy link
Member

My suggestion is about they needing to run in the container. If the license part were in another extension that didn't need to run in the container... wouldn't that help?

I don't fully understand your comment, but our licensing mechanism needs to run where ever Wallaby is running. If you are using a container, that's where it needs to run.

@Noriller
Copy link
Author

basically this:
image

@smcenlly
Copy link
Member

Wallaby will now automatically pass your license to remote container instances. Please update to the latest version of Wallaby for VS Code (v1.0.334) and after restarting VS Code, Wallaby should start to automatically apply your license when your remote container is launched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants