-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Support passing license to VS Code Remote Container Instances #2937
Comments
Unfortunately Wallaby/Quokka need to run in the container I'll update the issue title as a feature request to support passing license to remote-container instances (we're not sure if this is technically possible). |
My suggestion is about they needing to run in the container.
If the license part were in another extension that didn't need to run in
the container... wouldn't that help?
…On Wed, Feb 23, 2022 at 7:36 PM Simon McEnlly ***@***.***> wrote:
Since there are extensions that run in the "main" vscode and others that
run remote, and I don't know if it would work, wouldn't an extension that
"prefers" to work on the main vscode be able to fix having to change the
containers?
Unfortunately Wallaby/Quokka need to run in the container
------------------------------
I'll update the issue title as a feature request to support passing
license to remote-container instances (we're not sure if this is
technically possible).
—
Reply to this email directly, view it on GitHub
<#2937 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM7EPT7FDGEOMDJK5HB7HYTU4VOQBANCNFSM5PFQSTSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I don't fully understand your comment, but our licensing mechanism needs to run where ever Wallaby is running. If you are using a container, that's where it needs to run. |
Wallaby will now automatically pass your license to remote container instances. Please update to the latest version of Wallaby for VS Code ( |
I've tried using devcontainers on vscode and saw that it needs to run in the container so you need to either add the license or do like the tutorial: https://wallabyjs.com/docs/intro/get-started-vscode.html#remote-containers
since there are extensions that run in the "main" vscode and others that run remote, and I don't know if it would work, wouldn't an extension that "prefers" to work on the main vscode be able to fix having to change the containers?
Could also add to that some easy place to change some options and config (both wallaby and quokka)
The text was updated successfully, but these errors were encountered: