Human readable diff output and command line tool #2

Merged
merged 6 commits into from Jun 12, 2012

Projects

None yet

2 participants

@chrismcg

Hi Jonathan,

I've been playing around with a command line tool and more human readable output and was wondering what you thought? I don't consider this finished yet. I thought I'd run it by you to see if you've any ideas similar to this you haven't implemented yet.

Chris

@wallace
Owner

This looks great. I love the tests and implementation; great work!

My ultimate goal is to use the yamldiff library within the context of an iOS macruby/rubymotion app for designers to work with translation and localization files within rails.

But, I also like that it can be used in other contexts as well. 👍

@wallace wallace merged commit c51f36d into wallace:master Jun 12, 2012
@wallace
Owner

Heh, I just reread your initial comment after I went ahead and biased towards action here and merged it in.

If you have some revisions to add later, feel free to open up another pull request. Otherwise, I'll release a new version of the gem here in the next few days.

@chrismcg

No worries, thanks for merging. Was thinking of two things.

1) Moving the key names to the start so it's foo.bar.baz: as I think that's easier to scan
2) Making the content diffing optional with a command line switch

WDYT?

My motivation for this is i18n related too. It will be useful both for myself and users of a rails translation management app I work on: http://www.localeapp.com

@wallace
Owner

1) I'm not sure what you mean here. Are you saying that you'd prefer key.root.namespace over root.namespace.key?
chrismcg@438285c#L1R5

2) Totally agree here.

Re: http://www.localeapp.com, I love it!

@chrismcg

No, I meant root.namespace.key: rather than : root.namespace.key. Will get around to a patch soon I hope.

Glad you like localeapp :)

@wallace
Owner

Ah, gotcha. Yeah, I'm fine with moving the colon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment