Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human readable diff output and command line tool #2

Merged
merged 6 commits into from Jun 12, 2012

Conversation

chrismcg
Copy link
Contributor

Hi Jonathan,

I've been playing around with a command line tool and more human readable output and was wondering what you thought? I don't consider this finished yet. I thought I'd run it by you to see if you've any ideas similar to this you haven't implemented yet.

Chris

@wallace
Copy link
Owner

wallace commented Jun 12, 2012

This looks great. I love the tests and implementation; great work!

My ultimate goal is to use the yamldiff library within the context of an iOS macruby/rubymotion app for designers to work with translation and localization files within rails.

But, I also like that it can be used in other contexts as well. 👍

wallace added a commit that referenced this pull request Jun 12, 2012
Human readable diff output and command line tool
@wallace wallace merged commit c51f36d into wallace:master Jun 12, 2012
@wallace
Copy link
Owner

wallace commented Jun 12, 2012

Heh, I just reread your initial comment after I went ahead and biased towards action here and merged it in.

If you have some revisions to add later, feel free to open up another pull request. Otherwise, I'll release a new version of the gem here in the next few days.

@chrismcg
Copy link
Contributor Author

No worries, thanks for merging. Was thinking of two things.

  1. Moving the key names to the start so it's foo.bar.baz: as I think that's easier to scan
  2. Making the content diffing optional with a command line switch

WDYT?

My motivation for this is i18n related too. It will be useful both for myself and users of a rails translation management app I work on: http://www.localeapp.com

@wallace
Copy link
Owner

wallace commented Jun 13, 2012

  1. I'm not sure what you mean here. Are you saying that you'd prefer key.root.namespace over root.namespace.key?
    chrismcg@438285c#L1R5

  2. Totally agree here.

Re: http://www.localeapp.com, I love it!

@chrismcg
Copy link
Contributor Author

No, I meant root.namespace.key: rather than : root.namespace.key. Will get around to a patch soon I hope.

Glad you like localeapp :)

@wallace
Copy link
Owner

wallace commented Jun 14, 2012

Ah, gotcha. Yeah, I'm fine with moving the colon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants