Improve error reporting to the user

walles · Sep 1, 2020 · 415997c · 415997c
1 parent 08c44b5
commit 415997c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/px/px.py b/px/px.py
@@ -79,10 +79,23 @@ def install(argv):
 
 # This is the setup.py entry point
 def main():
+    argv = list(sys.argv)
+
+    loglevel = logging.ERROR
+    while '--debug' in argv:
+        argv.remove('--debug')
+        loglevel = logging.DEBUG
+
+    stringIO = six.StringIO()
+    configureLogging(loglevel, stringIO)
+
     try:
-        _main(sys.argv)
+        _main(argv)
     except Exception:
-        handleLogMessages(traceback.format_exc())
+        LOG = logging.getLogger(__name__)
+        LOG.exception("Uncaught Exception")
+
+    handleLogMessages(stringIO.getvalue())
 
 
 def configureLogging(loglevel, stringIO):
@@ -124,11 +137,6 @@ def handleLogMessages(messages):
 
 
 def _main(argv):
-    loglevel = logging.ERROR
-    while '--debug' in argv:
-        argv.remove('--debug')
-        loglevel = logging.DEBUG
-
     if len(argv) == 1 and os.path.basename(argv[0]).endswith("top"):
         argv.append("--top")
 
@@ -147,14 +155,10 @@ def _main(argv):
         install(argv)
         return
 
-    stringIO = six.StringIO()
-    configureLogging(loglevel, stringIO)
-
     if arg == '--top':
         # Pulling px_top in on demand like this improves test result caching
         from . import px_top
         px_top.top()
-        handleLogMessages(stringIO.getvalue())
         return
 
     if arg == '--help':
@@ -175,7 +179,6 @@ def _main(argv):
     try:
         pid = int(arg)
         px_processinfo.print_pid_info(sys.stdout.fileno(), pid)
-        handleLogMessages(stringIO.getvalue())
         return
     except ValueError:
         # It's a search filter and not a PID, keep moving

diff --git a/px/px_loginhistory.py b/px/px_loginhistory.py
@@ -7,7 +7,6 @@
 import dateutil.tz
 
 if False:
-    import logging  # NOQA
     from typing import Set, Optional  # NOQA
 
 LOG = logging.getLogger(__name__)

diff --git a/px/px_pager.py b/px/px_pager.py
@@ -8,7 +8,6 @@
 
 if False:
     # For mypy PEP-484 static typing validation
-    import logging               # NOQA
     from . import px_process     # NOQA
     from typing import List      # NOQA
     from typing import Optional  # NOQA

diff --git a/px/px_top.py b/px/px_top.py
@@ -21,7 +21,6 @@
 
 if False:
     # For mypy PEP-484 static typing validation
-    import logging               # NOQA
     from typing import List      # NOQA
     from typing import Dict      # NOQA
     from typing import Union     # NOQA