-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename walletconnect react native package #3
Comments
Technically it's a 2-way communication so both the client/app/dapp and the wallet will listen, so I wouldn't call it listener. There will be a lot of renaming in the future, specially when we move into a multi-wallet integration but I would maybe just change There may be 5-10 wallets but there will be 1000s of dapps, so this needs to be intuite to install by running What I would like to do instead is have multiple versions of walletconnect client library that include different levels of features: full featured = cc @ligi @jdkanani @jinchung @Dobrokhvalov @vikmeup @localethereumMichael |
Discussion to be followed on: https://discuss.walletconnect.org/t/renaming-javascript-libraries/73 |
WalletConnect react-native sdk is not dependent to react-native platform. The sdk's indirect dependency is
crypto
(a node built-in module) viawalletconnect-core
and firebase in-app messaging. So, whenever any environment (be it PWA or mobile app) has access to these dependencies, the developer of these platforms (PWA or mobile app) can use this sdk.The names could be changed to something like:
The text was updated successfully, but these errors were encountered: