58/On switch network restart geth service is necessary #127
Conversation
friedger
changed the title
|
Unfortunately we cannot do it that way - the node has to listen on changes to the current network definition and restart then - otherwise we get in real trouble here: #99 |
| @@ -48,7 +57,30 @@ open class SwitchNetworkActivity : AppCompatActivity() { | |||
|
|
|||
| private fun getAdapter() = NetworkAdapter(AllNetworkDefinitions) { | |||
| networkDefinitionProvider.setCurrent(it) | |||
| finish() | |||
| if (GethLightEthereumService.shouldRun) { | |||
There was a problem hiding this comment.
Unfortunately we cannot do it that way - the node has to listen on changes to the current network definition and restart then - otherwise we get in real trouble here: #99
Also if we would switch the network e.g. after scanning erc-681 with a different network-id this would not work - should listen on the effect and not one cause
There was a problem hiding this comment.
Unfortunately we cannot do it that way - the node has to listen on changes to the current network definition and restart then - otherwise we get in real trouble here: #99
Also if we would switch the network e.g. after scanning erc-681 with a different network-id this would not work - should listen on the effect and not one cause
if geth service should run then stop it and restart it
see #58
While stopping an alert is shown:
The notifications now shows the network name:
