This repository has been archived by the owner on Mar 31, 2021. It is now read-only.
Corrections to the README file. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been working through a basic use of BigBen using the readme. I have come across a few things which are not quite right. 1. The `eventTime` field will 400 if using the three-digit millisecond specification. This works with 2 digits, however. 2. The _http sample_ specifies the field `properties`, however using that as a member results in a 400. Have corrected this to the expected `props` field. I haven't tested with the `kafka` example and have left it unchanged. 3. The `find an event` sample uses `/event/` in the path. I have corrected this to be `/events/`
|
|
|
I have alerted the project owner @sandeepmalik to ensure he takes a look. |
|
Thanks @ShaunEgan for your feedback and corrections. |
|
You're welcome :) |
ShaunEgan
added a commit
to ShaunEgan/bigben
that referenced
this pull request
Sep 17, 2018
This was missed in walmartlabs#1. This update simply makes the schema match the example requests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working through a basic use of BigBen using the readme. I have come across a few things which are not quite right.
eventTimefield will 400 if using the three-digit millisecond specification. This works with 2 digits, however.properties, however using that as a member results in a 400. Have corrected this to the expectedpropsfield. I have corrected the Kafka example based on thisfind an eventsample uses/event/in the path. I have corrected this to be/events/