This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Create a separate fn scope for each $ instance #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines a per-page $.fn instance that can be modified safely by pages without causing their content to be retained or unexpected cross context $ operations. The initial attempt at this was incorrect, thus the removal of the Object.create call.
| @@ -12,8 +12,14 @@ module.exports = exports = function jQuery(window, html, exec, options) { | |||
| html = undefined; | |||
|
|
|||
| function query(selector, context) { | |||
| /* jshint -W103 */ | |||
There was a problem hiding this comment.
The use of __proto__. Jshint does not like but it's in the spec as of ES6. Generally we don't want to use this since there is performance overhead.
|
lgtm |
kpdecker
added a commit
that referenced
this pull request
Sep 18, 2014
Create a separate fn scope for each $ instance
|
Released in 0.14.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines a per-page $.fn instance that can be modified safely by pages without
causing their content to be retained or unexpected cross context $ operations.