This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Make ajax cache work with catbox 4.x #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url = options.url; | ||
|
|
||
| if (/=\?/.test(url)) { | ||
| url = url.replace('=?', '=$jsonp$'); |
There was a problem hiding this comment.
This changes the url that is cached, right? Do we care?
There was a problem hiding this comment.
I don't see any reason to care.
kpdecker
added a commit
that referenced
this pull request
Nov 10, 2014
Make ajax cache work with catbox 4.x
|
Released in 0.16.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about this line https://github.com/walmartlabs/fruit-loops/compare/catbox-4?expand=1#diff-2dd9daca757e2378de6a629d4b2f3c0dR52. We are basically replacing existing rules, which may have been set up somewhere else. In fact, we do pass
expiresInwhen constructing the cache policy in scotsman: https://github.com/walmartlabs/scotsman/blob/master/lib/index.js#L120. It seems like it doesn't matter in this case becausegenerateFuncprovidesttlexplicitly, but generally this is not safe. Doing_.extend(ajaxCache.rule, {generateFunc: generateFunc}is also not safe becauseajaxCache.ruleis not public API.