Use React 18 types and useId hook for identifiers #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieuauger
force-pushed
the
useId-fix-react-types
branch
from
1d8d75e
to
47c74b6
Compare
matthieuauger
changed the title
|
Hi @mazurroman, for this PR I needed to change a few types, I performed an extensive functional test, compiling a program, using the kbar, adding an argument but it would be useful if you quickly can test typical use-cases to ensure nothing has been broken. |
|
Great work Matthieu ! I reviewed the code and I tested a maximum of features, LGTM ! |
remybar
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous assumption was erroned, project already uses React 18 but we didn't upgrade the related typescript types so we weren't able to import the new useId() hook.
This PR upgrade the types version and allow usage of useId() instead of hardcoded id
Fixes #75 comment
Cancels #98