Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the way of finding the padding #43

Merged

Conversation

xmartinez15
Copy link
Contributor

From what i have been testing, padding is usually 6 or 7 now, so the access token cannot be parsed anymore. Anyway, i think it's better to adopt a safer solution like looking for all possible padding values (1 to 16).

@philpotisk philpotisk merged commit ee8e754 into walt-id:master Oct 18, 2021
@philpotisk
Copy link
Contributor

@xmartinez15 Thanks for fixing this issue, before we even recorded it 😅
As a matter of fact, the problem was only visible after manually enabling the integration test EssifCommandTest by adding the bearer token to file data/ebsi/bearer-token.txt.
By doing so, I could verify that your fix is working fine 👍

@xmartinez15 xmartinez15 deleted the fix-padding-decrypted-access-token branch October 18, 2021 15:46
waltkb added a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants