Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

productivity modules #2

Closed
23johnw opened this issue Aug 12, 2017 · 10 comments
Closed

productivity modules #2

23johnw opened this issue Aug 12, 2017 · 10 comments
Assignees

Comments

@23johnw
Copy link

23johnw commented Aug 12, 2017

i can't seem to add productivity modules to refineries, i had a look at the code and it should allow them i think, i may be wrong. Is this intentional i can add productivity modules to vanilla refineries, thanks

@walter-exit
Copy link
Owner

Hi John,

No, this is not intentional. Any module should be able to fit into these refineries. I haven't played recently, and I do know they change the game a lot, so I probably need to update this mod to get it working again.

It would mean I need to take a look at the official refinery code of the game, see what changed, and then apply those changes to the mod.

Due to the game being still heavily under development, this happens once every few weeks or months. Sorry.

I'll release a new update soon. Hopefully tomorrow if my private life allows me.

Much thanks for notifying me, it helps a lot to keep this mod up and running.

@23johnw
Copy link
Author

23johnw commented Aug 13, 2017

Great for getting back so quick, I understand life gets in the way of factorio, it comes up with something like "only use productity on intermediate products" I had a look at the code for your refinery and the base game and it all looked the same. Cheers

@walter-exit
Copy link
Owner

I found the problem. The productivity module explicitly requires to have all the allowed intermediate products (recipies) listed in order for it to be allowed in any building.

This behaviour was probably like this from the start. But I'll release 1.3.2 today with a fix. This version will add my specialized refinery recipes to the allowed intermediate products for productivity modules.

I tried it in-game and it worked. I'd love to hear from you if it is solved in 1.3.2

@walter-exit walter-exit self-assigned this Aug 13, 2017
walter-exit referenced this issue Aug 13, 2017
Allow productivity modules - in a bit more memory efficient way
@23johnw
Copy link
Author

23johnw commented Aug 13, 2017

Hi, it's allowing me to insert productivity module 1 not 2 or 3, still comes up with "productivity only allowed for intermediate Product",

thanks for the quick response/ help
much appreciated

john

@23johnw
Copy link
Author

23johnw commented Aug 13, 2017

i am only using your mod and creative mod, just to allow all research on a new game to try it,

@23johnw
Copy link
Author

23johnw commented Aug 13, 2017

require("config")
require("core")
require("prototypes.category")
require("prototypes.entities")
require("prototypes.item")
require("prototypes.recipe")
require("prototypes.technology")
data.raw["assembling-machine"]["oil-refinery"].fast_replaceable_group = "assembling-machine"
-- Allow productivity modules in the specialized refineries by adding the recipies as intermediate products
table.insert(data.raw.module["productivity-module"].limitation, "specialized-refining-petroleum")
table.insert(data.raw.module["productivity-module"].limitation, "specialized-refining-light-oil")
table.insert(data.raw.module["productivity-module"].limitation, "specialized-refining-heavy-oil")
table.insert(data.raw.module["productivity-module-2"].limitation, "specialized-refining-petroleum")
table.insert(data.raw.module["productivity-module-2"].limitation, "specialized-refining-light-oil")
table.insert(data.raw.module["productivity-module-2"].limitation, "specialized-refining-heavy-oil")
table.insert(data.raw.module["productivity-module-3"].limitation, "specialized-refining-petroleum")
table.insert(data.raw.module["productivity-module-3"].limitation, "specialized-refining-light-oil")
table.insert(data.raw.module["productivity-module-3"].limitation, "specialized-refining-heavy-oil")

@23johnw
Copy link
Author

23johnw commented Aug 13, 2017

That fixed it, looks like you have to name all the productivity modules separately.
cheers

@walter-exit
Copy link
Owner

Ah, this needs to be done per module?

In that case the commit from atehxx is indeed more near, now I get it.

c3ba21f

I'll update to 1.3.3 asap for everybody else

Thanks for your help John

@walter-exit
Copy link
Owner

I meant neat, not near

@23johnw
Copy link
Author

23johnw commented Aug 13, 2017

No problems, you did most of the work i just played with it.

thanks for making a great mod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants