This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Modify the API structure for Flink-Flux compilation framework #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime / service / config framework
walterddr
commented
May 12, 2019
| @@ -34,7 +34,7 @@ | |||
| private int compiledSourceCount; | |||
| private DataStream dataStream = null; | |||
There was a problem hiding this comment.
This should not be contained in this.
compilerVertex should be abstract and needs to have an impl specific to the datastream API components.
| @@ -52,7 +53,7 @@ | |||
| /** | |||
There was a problem hiding this comment.
All of the components here in the map should be extending from CompilerVertex so that the context does not depend on any specific Compiler impl.
|
|
||
| import com.uber.athena.flux.flink.compiler.api.CompilerVertex; |
There was a problem hiding this comment.
FluxContext should be moved to top level API since it should not link with any compiler specific. this context belongs to flux.
1. Compiler API level contains the compiling vertex encap; the compilation graph algorithm: BFS; the compilation context that stores intermediate compilation data 2. Impl of compiler moved to a datastream specific impl. later on can support operator level. 3. Separated out specific utilities and API level independent components such as the compiler suite.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the compilation framework to separate the APIs: