Fix to consider wrapping element instead of overall browser window.

walterra · Jul 6, 2022 · 598c0bf · 598c0bf
1 parent 38c0028
commit 598c0bf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## [`main`](https://github.com/walterra/d3-milestones/tree/main)
 
-No public interface changes since `v1.4.0`.
+- Fix `autoResize` to consider wrapping element instead of overall browser window. ([#62](https://github.com/walterra/d3-milestones/issues/62))
 
 ## [`v1.4.0`](https://github.com/walterra/d3-milestones/tree/v1.4.0)
 

diff --git a/src/main.js b/src/main.js
@@ -131,25 +131,23 @@ export default function milestones(selector) {
     setLabelFormat(aggregateFormats[d]);
   }
 
+  const autoResize = { current: DEFAULTS.AUTO_RESIZE };
+
   const resizeHandler = () => {
     if (dom.select(selector).node() !== null) {
       window.requestAnimationFrame(() => {
-        render();
+        if (autoResize.current) {
+          render();
+        }
       });
-    } else {
-      window.removeEventListener('resize', resizeHandler);
     }
   };
 
-  let autoResize = DEFAULTS.AUTO_RESIZE;
-  window.addEventListener('resize', resizeHandler);
+  const resizeObserver = new ResizeObserver(resizeHandler);
+  resizeObserver.observe(document.querySelector(selector));
+
   function setAutoResize(d) {
-    autoResize = d;
-    if (autoResize) {
-      window.addEventListener('resize', resizeHandler);
-    } else {
-      window.removeEventListener('resize', resizeHandler);
-    }
+    autoResize.current = d;
   }
 
   function render(data) {