Integrate grid widget #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapot65
commented
Jul 30, 2020
kapot65
commented
- Update GridWidget
- Move Plotly.js lib to waltz-shared-libs
… HemlWebpackPlugin- Npm commands now works on Windows too- Add waltz-shared-libs to project
… integrate-grid-widget
…tz into integrate-grid-widget
…tz into integrate-grid-widget
- move Plotly.js to shared libs
…tz into integrate-grid-widget
Ingvord
reviewed
Jul 30, 2020
| const grid_widget = webix.protoUI({ | ||
| name: 'grid_widget', | ||
|
|
||
| defaults:{ | ||
| borderless:true | ||
| }, | ||
|
|
||
| addDevice(device){ |
There was a problem hiding this comment.
This will break dnd functionality as this method is responsible for adding new devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.